Pass data to PayPal to pre-fill billing info #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There might be a better check for whether the swipestripe-addresses module is installed, I just couldn't think of anything. If anyone has a better suggestion, totally open to it. |
|
@RuthAdele: Thanks for this pull request and sorry it has taken me so long to respond. I like the idea, it feels like this should perhaps be implemented as a hook or similar so that this module is not concerned at all whether SwipeStripe addresses is installed. In any case it would be good to move to Omnipay which might have a better approach anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If swipestripe-addresses module is present, pass the billing data the user has just filled in to PayPal, so they don't need to fill it out all over again.